Make SplitQuotedString always returns a result
#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the function finds an opening quote character and does not find the closing quote character, it will return an error. Previously, in case of error, the returned split array was always empty. Now, in any case, the function will return the split array up to the point where the error occurred.
per1234
added
type: enhancement
alessio-perugini
approved these changes
Jun 5, 2024
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Jun 5, 2024
The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Jun 5, 2024
The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Jun 5, 2024
The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Jun 5, 2024
The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Jun 13, 2024
The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Aug 8, 2024
The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Jan 20, 2025
The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Feb 13, 2025
The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Jun 23, 2025
The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Jul 14, 2025
The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42
cmaglie
added a commit
to arduino/arduino-cli
that referenced
this pull request
Jul 25, 2025
…2625) * Simplified error reporting in library detection There is no need to duplicate the preprocessResult/Err variables. This also simplifies naming making it more straighforward. * Remove useless targetFilePath variable * Slight improvement of removeBuildFromSketchFiles * Rename variables for clarity * Removed hardcoded build.warn_data_percentage in build.options file Also fixed the "low memory" warning printer. * Renamed variables for clarity * Renamed variables for clarity * Pre-compute sourceFile fields, and save the in the includes.cache * Added ObjFileIsUpToDate method to sourceFile * Implemented parallel task runner * Simplify use of properties.SplitQuotedString The new release of the library allow ignoring the returned error. arduino/go-properties-orderedmap#42 * Use runner.Task in GCC preprocessor It slightly simplifies code, but also provide the basis for the next commits. * Parallelize library discovery phase in compile * The number of jobs in library detection now follows --jobs flag * Reordered properties construction for clarity * Reordered compileFileWithRecipe for clarity * Added integration test * fix: libraries are recompiled if the list of include paths changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the function
SplitQuotedStringfinds an opening quote character and does not find the closing quote character, it will return an error.Previously, in case of error, the returned split array was always empty.
Now the function will return the split array up to the point where the first error occurred, allowing the caller to ignore the error if needed.